Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda): web-view functionality and fixes for serverless land #6687

Open
wants to merge 9 commits into
base: feature/serverlessland
Choose a base branch
from
Open

feat(lambda): web-view functionality and fixes for serverless land #6687

wants to merge 9 commits into from

Conversation

Vandita2020
Copy link
Contributor

@Vandita2020 Vandita2020 commented Feb 26, 2025 •
edited
Loading

Problem

This PR adds the web view functionality for patterns. It addresses an issue with the metadata.json file path for the extension by specifying the path after the build step in the copyFile.ts file.

Solution

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Vandita2020 Vandita2020 marked this pull request as ready for review February 26, 2025 22:38
@Vandita2020 Vandita2020 requested a review from a team as a code owner February 26, 2025 22:38
jpinkney-aws
jpinkney-aws reviewed Feb 27, 2025
View reviewed changes
packages/core/src/awsService/appBuilder/serverlessLand/main.ts
let createResult: Result = 'Succeeded'
let reason: string | undefined
let metadataManager: MetadataManager

try {
metadataManager = MetadataManager.getInstance()
// Launch the project creation wizard
const config = await launchProjectCreationWizard(extContext)
const config = await launchProjectCreationWizard(extContext, ctx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just use globals.context instead of plumbing it through everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpinkney-aws jpinkney-aws jpinkney-aws left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vandita2020 @jpinkney-aws